expanded quests to Wilderness Hut (#6347) #6365
Conversation
|
Have you tested this changes? I have no real opinion on whether this changes make sense. |
Yep! |
| @@ -23,6 +23,7 @@ class AddWheelchairAccessBusiness : OsmFilterQuestType<WheelchairAccess>(), Andr | |||
| or amenity = recycling and recycling_type = centre | |||
| or amenity = social_facility and social_facility ~ food_bank|clothing_bank|soup_kitchen|dairy_kitchen | |||
| or tourism = information and information = office | |||
| or tourism = wilderness_hut | |||
There was a problem hiding this comment.
this one seems most dubious of proposed - I would expect wilderness hut to be in wilderness such as mountains and therefore not accessible with wheelchair anyway
but I have no great experience with those and maybe sizeable number is in places where you can get wheelchair to, but cannot get one inside (or only with major difficulty)
but I am not familiar with such places
There was a problem hiding this comment.
Hmm, I do agree. I have yet to vist a wheelchair accessible hut, however there are currently 13 marked with wheelchair=yes, and 137 with wheelchair = no. Though these small numbers are likely not representative.
However I think since this is a disabled by default quest, and these huts are quite sparse I feel like this would not be to spammy.
There was a problem hiding this comment.
I am not going to block altogether asking about wheelchair status, but I am also not going to merge with it.
I guess that either you can wait for someone else with merge ability to review one way or another or drop wheelchair part.
For what it is worth I asked on osm IRC and got similar opinion, that wheelchair is dubious here
I feel like this would not be to spammy.
for me bigger problem is that it would be highly confusing
There was a problem hiding this comment.
Ok, I reverted the wheelchair change
...kotlin/de/westnordost/streetcomplete/quests/wheelchair_access/AddWheelchairAccessBusiness.kt
Outdated
Show resolved
Hide resolved
app/src/androidMain/kotlin/de/westnordost/streetcomplete/quests/place_name/AddPlaceName.kt
Outdated
Show resolved
Hide resolved
|
I guess you can make a new PR that would add only wheelchair (and yes, I should have rebased and squashed it, not only rebased, sorry - at least it ended with three commits, not three hundreds of them) |
|
And thanks for contribution! |
resolves #6347