http_assertions: honour the msgAndArgs provided with each assertion #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73f5f7f to
135b468
Compare
brackendawson
previously approved these changes
Feb 23, 2024
|
I think the existing tests are good enough to prove that there is no regression. None of them are passing the custom message. That ensures backward compatibility. Actually, let me add a message in some of the existing tests, just for the sake of it. |
A mix of using and not using msgAndArgs will ensure that there is no regression.
brackendawson
requested changes
Feb 23, 2024
This commit also adds the method `Failed() bool` to the mockTestingT struct. This is usefull for asserting failure in tests
brackendawson
requested changes
Feb 23, 2024
brackendawson
approved these changes
Feb 23, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The http assertions do not use the
msgAndArgsat all. This commit fixes that.Related issues
Not directly related, but stemmed from looking into #316
Closes #1324