Skip to content

Add support for UNIX time with nanoseconds to template functions #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 2, 2024
Merged

Add support for UNIX time with nanoseconds to template functions #300

merged 1 commit into from
May 2, 2024
+116 −4

Conversation

tksm
Copy link
Contributor

@tksm tksm commented May 2, 2024

This commit adds support for UNIX time seconds with nanoseconds (e.g., 1136171056.02) to the following template functions:

  • toRFC3339Nano
  • toTUC
  • toTimestamp

As described in #297, the toUTC currently fails to parse a timestamp like 1580306777.04728, resulting in the incorrect date.

$ echo '{"ts":1580306777.04728,"msg":"Pod status updated"}' | ./stern --stdin=true --template '{{- with $msg := .Message | tryParseJSON -}}{{- toUTC $msg.ts -}}{{- " - " -}}{{- $msg.msg -}}{{- end -}}'
0001-01-01 00:00:00 +0000 UTC - Pod status updated

With this commit, the toUTC can correctly parse the timestamp with nanoseconds.

2020-01-29 14:06:17.04728 +0000 UTC - Pod status updated%

Fixes #297

@tksm tksm mentioned this pull request May 2, 2024
Closed
rkmathi
rkmathi approved these changes May 2, 2024
View reviewed changes
Copy link
Member

@rkmathi rkmathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥳

@tksm tksm merged commit 0d580ff into stern:master May 2, 2024
@tksm tksm deleted the support-nanosec branch May 2, 2024 08:45
@chenrui333 chenrui333 mentioned this pull request May 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmathi rkmathi rkmathi approved these changes

@superbrothers superbrothers Awaiting requested review from superbrothers superbrothers is a code owner

@floryut floryut Awaiting requested review from floryut floryut is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

toUTC unable to parse Kubernetes controller-runtime log timestamps
2 participants
@tksm @rkmathi