Add --stdin for stdin log parsing
#292
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When Log and TailOptions are used by other classes it is now more obvious that they're not hard lined to Tail.
FileTail is heavily based on Tail but I saw no obvious way to abstract the common parts of the classes to not duplicate them. FileTail is so small it's hardly noticeable anyway.
tksm
reviewed
Mar 26, 2024
There was a problem hiding this comment.
I'm sorry for the delayed reply.
This feature will also be great for testing templates 👍. I would like to incorporate this feature, but I would like to confirm that at least one other maintainer agrees before proceeding. @floryut @rkmathi @superbrothers What do you think?
Thanks for the PR!
Also moving file tailing to main thread as there are no parallel tails with that config.
rkmathi
approved these changes
Mar 29, 2024
|
Awesome, thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage:
This PR adds the
--stdinflag for parsing logs fromstdininstead of pulling them from k8s. It creates a new "tail" struct,FileTail, which is heavily based on the originalTail. The new class is quite slim and I didn't find any meaningful way to combine the two, so they are mostly their own separate thing. They do share some helper functions andTailOptionswhich I moved to a "utils" file.It's not uncommon for CLI tools to use
-to read fromstdinbut I didn't find support for that inpflag, and I'm not sure it's better than--stdinanyway. (e.g like vimecho "Hello" | vim -, and for sternstern - < ./service.log)Feedback welcome.
Implements #291