Update dependencies and tools #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2023 09:11
b3e2b16 to
39c8330
Compare
tksm
commented
Aug 16, 2023
| @@ -54,7 +54,7 @@ verify-readme: | |||
|
|
|||
| .PHONY: validate-krew-manifest | |||
| validate-krew-manifest: $(VALIDATE_KREW_MAIFEST) | |||
| $(VALIDATE_KREW_MAIFEST) -manifest dist/stern.yaml -skip-install | |||
| $(VALIDATE_KREW_MAIFEST) -manifest dist/krew/stern.yaml -skip-install | |||
There was a problem hiding this comment.
📝 The manifest path was changed in goreleaser/goreleaser@76ce66c.
tksm
commented
Aug 16, 2023
| @@ -521,7 +521,7 @@ func TestOptionsSternConfig(t *testing.T) { | |||
| c.AllNamespaces = true | |||
| c.LabelSelector = labelSelector | |||
| c.FieldSelector = fieldSelector | |||
| c.TailLines = pointer.Int64(10) | |||
| c.TailLines = ptr.To[int64](10) | |||
There was a problem hiding this comment.
📝 The pointer package was deprecated in kubernetes/utils@dc1a5d8.
floryut
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the dependencies for the release of Kubernetes v1.28.0. I checked the latest versions of the tool on the following URLs.