Skip to content

Allow an empty config file #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2023
Merged

Allow an empty config file #255

merged 1 commit into from
Apr 11, 2023
+8 −1

Conversation

tksm
Copy link
Contributor

@tksm tksm commented Apr 10, 2023

This PR allows an empty config file. Currently, stern fails as follows when the config file is empty. Please see go-yaml/yaml#639 for details.

$ touch /tmp/empty-sternconfig.yaml

$ dist/stern --config /tmp/empty-sternconfig.yaml .
Error: EOF
Usage:
  stern pod-query [flags]
# ...

rkmathi
rkmathi approved these changes Apr 10, 2023
View reviewed changes
Copy link
Member

@rkmathi rkmathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tksm tksm merged commit c76ea87 into stern:master Apr 11, 2023
@tksm tksm deleted the allow-empty-config branch April 11, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superbrothers superbrothers superbrothers approved these changes

@rkmathi rkmathi rkmathi approved these changes

@floryut floryut Awaiting requested review from floryut floryut is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tksm @superbrothers @rkmathi