Skip to content

Add dynamic completion for --node flag #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2023
Merged

Add dynamic completion for --node flag #244

merged 1 commit into from
Mar 5, 2023

Conversation

tksm
Copy link
Contributor

@tksm tksm commented Mar 5, 2023 •
edited
Loading

Fixes #242
This PR adds a dynamic completion for --node flag.

node-completion1.mov

rkmathi
rkmathi approved these changes Mar 5, 2023
View reviewed changes
Copy link
Member

@rkmathi rkmathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tksm tksm merged commit 59d4453 into stern:master Mar 5, 2023
@tksm tksm deleted the completion-node branch March 5, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmathi rkmathi rkmathi approved these changes

@superbrothers superbrothers Awaiting requested review from superbrothers superbrothers is a code owner

@floryut floryut Awaiting requested review from floryut floryut is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support filtering by the node name
2 participants
@tksm @rkmathi