Skip to content

Highlight matched strings in the log lines with the include option #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2023
Merged

Highlight matched strings in the log lines with the include option #231

merged 1 commit into from
Feb 18, 2023

Conversation

superbrothers
Copy link
Member

This PR changes to highlight matched strings in the log lines with the include option.

image

Closes #195

tksm
tksm reviewed Feb 18, 2023
View reviewed changes
tksm
tksm reviewed Feb 18, 2023
View reviewed changes
@superbrothers superbrothers force-pushed the highlight-matched-string branch from ab26290 to 2d79acd Compare February 18, 2023 23:20
@superbrothers
Copy link
Member Author

superbrothers commented Feb 18, 2023 •
edited
Loading

I've squashed the commits.

tksm
tksm approved these changes Feb 18, 2023
View reviewed changes
Copy link
Contributor

@tksm tksm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@tksm tksm merged commit 9fbaa18 into master Feb 18, 2023
@tksm tksm deleted the highlight-matched-string branch February 18, 2023 23:46
@tksm
Copy link
Contributor

tksm commented Feb 19, 2023 •
edited
Loading

📝 I like that -i ^ -i $ allows us to highlight lines without filtering.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tksm tksm tksm approved these changes

@floryut floryut Awaiting requested review from floryut floryut is a code owner

@rkmathi rkmathi Awaiting requested review from rkmathi rkmathi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

color the outputs with -i
2 participants
@superbrothers @tksm