Skip to content

Allow pods without labels to be selected in the resource query #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2023
Merged

Allow pods without labels to be selected in the resource query #223

merged 1 commit into from
Feb 5, 2023

Conversation

tksm
Copy link
Contributor

@tksm tksm commented Feb 4, 2023

This PR allows pods without labels to be selected in the resource query.

Currently, we will get the following error when we specify a pod without labels.

$ stern pod/nolabel
Error: resource pod/nolabel has no labels to select

apiVersion: v1
kind: Pod
metadata:
  name: nolabel
spec:
  containers:
  - name: nginx
    image: nginx:1.23.3

superbrothers
superbrothers approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@superbrothers superbrothers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@tksm tksm force-pushed the fix-pod-resource-query branch from f4396f2 to 5189962 Compare February 5, 2023 13:17
@tksm
Copy link
Contributor Author

tksm commented Feb 5, 2023

Thank you for the review! I rebased it in 5189962.

@superbrothers superbrothers merged commit fc51906 into stern:master Feb 5, 2023
@tksm tksm deleted the fix-pod-resource-query branch February 7, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superbrothers superbrothers superbrothers approved these changes

@floryut floryut Awaiting requested review from floryut floryut is a code owner

@rkmathi rkmathi Awaiting requested review from rkmathi rkmathi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tksm @superbrothers