Skip to content

Add all option to --container-state flag #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2023
Merged

Add all option to --container-state flag #222

merged 1 commit into from
Feb 5, 2023

Conversation

tksm
Copy link
Contributor

@tksm tksm commented Feb 3, 2023

This PR adds an all option to the --container-state flag.

This flag is helpful when we debug CrashLoopBackoff containers along with #221. Currently, it's a bit painful to select containers of all states.

# Before
$ stern --container-state running,terminated,running <QUERY>

# After
$ stern --container-state all <QUERY>

I think we can consider all as default in the future, as pointed out in #36 (comment), but it would be a breaking change, so I left it as is in this PR.

@superbrothers superbrothers merged commit 6e0d5fc into stern:master Feb 5, 2023
@tksm tksm deleted the container-state-all branch February 5, 2023 13:18
@tksm tksm mentioned this pull request Feb 8, 2023
Merged
@igortavtib igortavtib mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superbrothers superbrothers superbrothers approved these changes

@floryut floryut Awaiting requested review from floryut floryut is a code owner

@rkmathi rkmathi Awaiting requested review from rkmathi rkmathi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tksm @superbrothers