Skip to content

Add completion for flags with pre-defined choices #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2023
Merged

Add completion for flags with pre-defined choices #211

merged 1 commit into from
Jan 22, 2023

Conversation

tksm
Copy link
Contributor

@tksm tksm commented Jan 22, 2023

This PR adds completion for flags with pre-defined choices. These flags are currently --color, --completion, --container-state, and --output.

rkmathi
rkmathi approved these changes Jan 22, 2023
View reviewed changes
Copy link
Member

@rkmathi rkmathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😸

@rkmathi
Copy link
Member

rkmathi commented Jan 22, 2023

@tksm Could you rebase this?

@tksm tksm force-pushed the complete-flags-choices branch from 8f3f7d4 to 5d9d7e4 Compare January 22, 2023 09:21
@tksm
Copy link
Contributor Author

tksm commented Jan 22, 2023

@rkmathi Thanks for the review! I rebased it in 5d9d7e4.

@rkmathi rkmathi merged commit e03646c into stern:master Jan 22, 2023
@tksm tksm deleted the complete-flags-choices branch January 22, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rkmathi rkmathi rkmathi approved these changes

@superbrothers superbrothers Awaiting requested review from superbrothers superbrothers is a code owner

@floryut floryut Awaiting requested review from floryut floryut is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tksm @rkmathi