Add dynamic completion for a resource query #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tksm
commented
Jan 22, 2023
| @@ -234,8 +234,8 @@ stern -p | |||
| Stern supports command-line auto completion for bash, zsh or fish. `stern | |||
| --completion=(bash|zsh|fish)` outputs the shell completion code which work by being | |||
| evaluated in `.bashrc`, etc for the specified shell. In addition, Stern | |||
| supports dynamic completion for `--namespace` and `--context`. In order to use | |||
| that, kubectl must be installed on your environment. | |||
There was a problem hiding this comment.
I believe stern no longer requires kubectl, so I removed the line.
rkmathi
approved these changes
Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #159
This PR adds a dynamic completion for a resource query in the form
<resource>/<name>. The video below shows how this completion works.stern-resource-query.mov