Allow to use stern as a kubectl plugin #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that with this change, the archive files will no longer be wrapped in a directory. Since the krew plugin manifest generated by GoReleaser does not support wrapping in a directory, and the krew-index auto-approval does not work if the directory name contains a version. **Before** ``` $ tar -tf stern_1.20.1_darwin_amd64.tar.gz stern_1.20.1_darwin_amd64/LICENSE stern_1.20.1_darwin_amd64/stern ``` **After** ``` $ tar -tf stern_1.20.1-SNAPSHOT-5240615_darwin_amd64.tar.gz LICENSE stern ```
rkmathi
approved these changes
Dec 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to use stern as a kubectl plugin.
Note that with this change, the archive files will no longer be wrapped in a directory. Since the krew plugin manifest generated by GoReleaser does not support wrapping in a directory, and the krew-index auto-approval does not work if the directory name contains a version.
Before
After
In addition, I manually created a plugin manifest and added it to the krew-index. Therefore stern can already be installed via Krew.
Closes #25