Change the default of --container-state to all (#225)

Takashi Kusumi · web-flow · commit 2502c91f9c31 · 2023-02-19T09:05:41.000+09:00
diff --git a/README.md b/README.md
@@ -75,7 +75,7 @@ Supported Kubernetes resources are `pod`, `replicationcontroller`, `service`, `d
  `--color`                   | `auto`    | Force set color output. 'auto':  colorize if tty attached, 'always': always colorize, 'never': never colorize.
  `--completion`              |           | Output stern command-line completion code for the specified shell. Can be 'bash', 'zsh' or 'fish'.
  `--container`, `-c`         | `.*`      | Container name when multiple containers in pod. (regular expression)
- `--container-state`         | `running` | Tail containers with state in running, waiting, terminated, or all. 'all' matches all container states. To specify multiple states, repeat this or set comma-separated value.
+ `--container-state`         | `all`     | Tail containers with state in running, waiting, terminated, or all. 'all' matches all container states. To specify multiple states, repeat this or set comma-separated value.
  `--context`                 |           | Kubernetes context to use. Default to current context configured in kubeconfig.
  `--ephemeral-containers`    | `true`    | Include or exclude ephemeral containers.
  `--exclude`, `-e`           | `[]`      | Log lines to exclude. (regular expression)
diff --git a/cmd/cmd.go b/cmd/cmd.go
@@ -79,7 +79,7 @@ func NewOptions(streams genericclioptions.IOStreams) *options {
 
 		color:               "auto",
 		container:           ".*",
-		containerStates:     []string{"running"},
+		containerStates:     []string{stern.ALL_STATES},
 		initContainers:      true,
 		ephemeralContainers: true,
 		output:              "default",
diff --git a/stern/container_state.go b/stern/container_state.go
@@ -41,7 +41,7 @@ func NewContainerState(stateConfig string) (ContainerState, error) {
 		return ALL_STATES, nil
 	}
 
-	return "", errors.New("containerState should be one of 'running', 'waiting', or 'terminated'")
+	return "", errors.New("containerState should be one of 'running', 'waiting', 'terminated', or 'all'")
 }
 
 // Match returns ContainerState is matched

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ func NewContainerState(stateConfig string) (ContainerState, error) {`
`41`	`41`	`return ALL_STATES, nil`
`42`	`42`	`}`
`43`	`43`
`44`		`- return "", errors.New("containerState should be one of 'running', 'waiting', or 'terminated'")`
	`44`	`+ return "", errors.New("containerState should be one of 'running', 'waiting', 'terminated', or 'all'")`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`// Match returns ContainerState is matched`