Return error when output option is invalid (#235)

Takashi Kusumi · web-flow · commit 1c5aa2b0c402 · 2023-02-26T09:06:45.000+09:00
diff --git a/cmd/cmd.go b/cmd/cmd.go
@@ -362,6 +362,8 @@ func (o *options) generateTemplate() (*template.Template, error) {
 				t = fmt.Sprintf("  \"namespace\": \"{{color .PodColor .Namespace}}\",\n%s", t)
 			}
 			t = fmt.Sprintf("{\n%s\n}", t)
+		default:
+			return nil, errors.New("output should be one of 'default', 'raw', 'json', 'extjson', and 'ppextjson'")
 		}
 		t += "\n"
 	}
diff --git a/cmd/cmd_test.go b/cmd/cmd_test.go
@@ -254,6 +254,18 @@ func TestOptionsGenerateTemplate(t *testing.T) {
 `,
 			false,
 		},
+		{
+			"invalid output",
+			func() *options {
+				o := NewOptions(streams)
+				o.output = "invalid"
+
+				return o
+			}(),
+			"message",
+			"",
+			true,
+		},
 		{
 			"template",
 			func() *options {

Original file line number	Diff line number	Diff line change
`@@ -362,6 +362,8 @@ func (o options) generateTemplate() (template.Template, error) {`
`362`	`362`	`t = fmt.Sprintf(" \"namespace\": \"{{color .PodColor .Namespace}}\",\n%s", t)`
`363`	`363`	`}`
`364`	`364`	`t = fmt.Sprintf("{\n%s\n}", t)`
	`365`	`+ default:`
	`366`	`+ return nil, errors.New("output should be one of 'default', 'raw', 'json', 'extjson', and 'ppextjson'")`
`365`	`367`	`}`
`366`	`368`	`t += "\n"`
`367`	`369`	`}`