Skip to content

feat: allow for clean tag pushing #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 19, 2025
Merged

Conversation

zMynxx
Copy link
Contributor

@zMynxx zMynxx commented Mar 23, 2025

This PR contains the code change to allow this action to be invoked for performing a clean tag & push.
By clean I mean to commits are added, and no file changes are staged.
It is meant to be used in CD systems, where we wish to alter the tag, without allowing automation entities to modify the source code (anti-pattern). This action can now be used a the de-facto standard for perform git operations in a pipeline / automations.

@zMynxx
Copy link
Contributor Author

zMynxx commented Mar 23, 2025

Follow up for my initial request #360 (reply in thread)

@stefanzweifel
Copy link
Owner

Thanks for the taking the time to create a PR for this. I will take a closer look in the coming days (currently sick and not on my computer).

At first glance, I think looks good. I will definitely write a few Bats tests for this, so future other releases won't break this functionality.

Copy link
Owner

@stefanzweifel stefanzweifel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late reply here. Life got in the way.

Looks good to me, I will merge this now but will push some changes in a separate PR. As you've created this PR from a fork in an organisation, I can't push my changes to the PR. (Not your faults, this is a long standing issue of GitHub itself: https://github.com/orgs/community/discussions/5634)

One change is renaming the option from git_tag_only to create_git_tag_only. I've also added some tests.

@stefanzweifel stefanzweifel merged commit 11a6e5f into stefanzweifel:master Apr 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants