Skip to content

Conversation

dlipicar
Copy link
Contributor

A short summary which serves as a squashed-commit message.

A description to understand introduced changes without reading the code.

Important changes:

  • Something worth noting for reviewers.

Closes #

@dlipicar dlipicar requested review from saledjenic, friofry and vkjr July 28, 2025 15:56
@status-im-auto
Copy link
Member

status-im-auto commented Jul 28, 2025

Jenkins Builds

Click to see older builds (9)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 34fb07c #1 2025-07-28 15:59:11 ~2 min android 📦aar
✔️ 34fb07c #1 2025-07-28 16:00:33 ~3 min linux 📦zip
34fb07c #1 2025-07-28 16:01:32 ~4 min windows 📄log
✔️ 34fb07c #1 2025-07-28 16:03:01 ~5 min macos 📦zip
✖️ 34fb07c #1 2025-07-28 16:03:42 ~6 min tests 📄log
✔️ 34fb07c #1 2025-07-28 16:05:05 ~7 min tests-rpc 📄log
✔️ 34fb07c #1 2025-07-28 16:18:01 ~20 min ios 📦zip
✔️ 34fb07c #1 2025-07-28 16:25:39 ~28 min macos 📦zip
✖️ 34fb07c #2 2025-07-31 14:28:28 ~5 min tests 📄log
Commit #️⃣ Finished (UTC) Duration Platform Result
ff8bf27 #2 2025-08-01 11:22:32 ~2 min windows 📄log
✔️ ff8bf27 #2 2025-08-01 11:23:12 ~3 min android 📦aar
✔️ ff8bf27 #2 2025-08-01 11:23:55 ~4 min linux 📦zip
✔️ ff8bf27 #2 2025-08-01 11:25:39 ~5 min ios 📦zip
✔️ ff8bf27 #2 2025-08-01 11:26:59 ~7 min macos 📦zip
✔️ ff8bf27 #2 2025-08-01 11:28:49 ~8 min macos 📦zip
✖️ ff8bf27 #2 2025-08-01 11:29:51 ~9 min tests-rpc 📄log
✖️ ff8bf27 #3 2025-08-01 11:49:24 ~29 min tests 📄log
✔️ 55b3a05 #3 2025-08-01 11:30:23 ~2 min android 📦aar
55b3a05 #3 2025-08-01 11:31:02 ~2 min windows 📄log
✔️ 55b3a05 #3 2025-08-01 11:32:11 ~3 min linux 📦zip
✔️ 55b3a05 #3 2025-08-01 11:32:52 ~4 min ios 📦zip
✔️ 55b3a05 #3 2025-08-01 11:34:04 ~5 min macos 📦zip
✔️ 55b3a05 #3 2025-08-01 11:35:32 ~6 min macos 📦zip
✖️ 55b3a05 #3 2025-08-01 11:37:46 ~7 min tests-rpc 📄log
✔️ 55b3a05 #4 2025-08-01 12:15:40 ~26 min tests 📄log

@vkjr
Copy link
Contributor

vkjr commented Jul 31, 2025

@igor-sirotin, could we please merge this?
It is a fix needed for status-mobile patch.

@jrainville
Copy link
Member

@dlipicar @vkjr the tests really don,t like those changes. I doubt they are all flaky 😅
Could you check it out first please

@vkjr vkjr assigned vkjr and dlipicar Aug 1, 2025
@vkjr vkjr force-pushed the fix/make-router-only-use-active-networks branch from ff8bf27 to 55b3a05 Compare August 1, 2025 11:28
Copy link

codecov bot commented Aug 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/10.29.x@d9d9fd2). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             release/10.29.x    #6785   +/-   ##
==================================================
  Coverage                   ?   60.31%           
==================================================
  Files                      ?      850           
  Lines                      ?   105325           
  Branches                   ?        0           
==================================================
  Hits                       ?    63523           
  Misses                     ?    34194           
  Partials                   ?     7608           
Flag Coverage Δ
functional 25.69% <100.00%> (?)
unit 58.23% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
services/wallet/router/router.go 66.45% <100.00%> (ø)
services/wallet/router/router_test_data.go 100.00% <ø> (ø)

@vkjr
Copy link
Contributor

vkjr commented Aug 1, 2025

@igor-sirotin, @jrainville, tests fix was pushed :)

@igor-sirotin
Copy link
Collaborator

Oh interesting,TestEth is also broken on the release branch 🤔

@igor-sirotin igor-sirotin merged commit a9850d6 into release/10.29.x Aug 1, 2025
15 of 17 checks passed
@igor-sirotin igor-sirotin deleted the fix/make-router-only-use-active-networks branch August 1, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants