Skip to content

Use labels suggested by Kubernetes and Helm best practices #967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 18, 2025

Conversation

pinkavaj
Copy link
Contributor

@pinkavaj pinkavaj commented Jul 7, 2025

Close #496 Splited from #932

This improves the compatibility and makes it easier to work with various tools, which take advantake from the assumption of existence of those labels.

Keep the old labels for selectors for backward compatibility.

Also note there is slight change in behaviour of PDB which might be backward-incompatible in some rare cases, but it is IMHO edge-case when the release name changes and someone for some obscure reason depends on not scheduling the new pods to same K8s node as the old pod, so I consider this change benign.

The chart was tested with the following values:

reloader:
  deployment:
    replicas: 2
    priorityClassName:
  enableHA: true
  logFormat: json
  podDisruptionBudget:
    enabled: true
  podMonitor:
    enabled: true
  readOnlyRootFileSystem: true
  reloadOnCreate: true

This improves the compatibility and makes it easier to work with various tools,
which take advantake from the assumption of existence of those labels.

Keep the old labels for selectors for backward compatibility.

Also note there is slight change in behaviour of PDB which might
be backward-incompatible in some rare cases.
@msafwankarim msafwankarim merged commit 51ee0a1 into stakater:master Jul 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use standard kubernetes labels
2 participants