Add cronjob support #486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

bnallapeta merged 5 commits into stakater:master from kvandenhoute:feature/cronjob_trigger

Oct 4, 2023

Contributor

kvandenhoute commented Jun 30, 2023

Add support for cronjob triggers to Stakater.

On change of configmap/secret a job is created from a job


          add cronjob support

465767c

jkurek1 commented Jul 12, 2023

Hi @kvandenhoute,
It is really good feature. I have use case with Knative Services: #493
Using that approach CronJob can add annotations to Service.

It would be really good to have it.

jkurek1 mentioned this pull request

Reloader is not working with Knative Service #493

Open


          Merge branch 'master' into feature/cronjob_trigger

5e7f130

github-actions bot commented Jul 19, 2023

@MuneebAijaz Image is available for testing. docker pull ghcr.io/:SNAPSHOT-PR-486-5e7f1302


          Merge branch 'master' into feature/cronjob_trigger

3e7cc40

github-actions bot commented Jul 26, 2023

@karl-johan-grahn Image is available for testing. docker pull ghcr.io/:SNAPSHOT-PR-486-3e7cc40c

bnallapeta self-requested a review

August 9, 2023 08:27

bnallapeta reviewed

View reviewed changes

internal/pkg/callbacks/rolling_upgrade.go Outdated Show resolved Hide resolved

bnallapeta reviewed

View reviewed changes

internal/pkg/callbacks/rolling_upgrade.go Outdated Show resolved Hide resolved

bnallapeta reviewed

View reviewed changes

internal/pkg/handler/upgrade.go Outdated Show resolved Hide resolved

bnallapeta reviewed

View reviewed changes

internal/pkg/callbacks/rolling_upgrade.go Outdated Show resolved Hide resolved

bnallapeta reviewed

View reviewed changes

internal/pkg/callbacks/rolling_upgrade.go Outdated Show resolved Hide resolved

bnallapeta reviewed

View reviewed changes

internal/pkg/callbacks/rolling_upgrade.go Outdated Show resolved Hide resolved

bnallapeta reviewed

View reviewed changes

bnallapeta left a comment

Overall PR looks good except for the minor changes requested.

Stef Graces and others added 2 commits

September 29, 2023 15:39


          Merge branch 'master' into feature/cronjob_trigger

697923a


          Fix comments

4dfd0e5

Signed-off-by: stgrace <stefgraces@hotmail.com>

Contributor

stgrace commented Sep 29, 2023

@bnallapeta All requested changes should be fixed now

github-actions bot commented Sep 29, 2023

@stgrace Image is available for testing. docker pull ghcr.io/stakater/reloader:SNAPSHOT-PR-486-4dfd0e51

bnallapeta approved these changes

View reviewed changes

bnallapeta merged commit 5033d67 into stakater:master

RockyMM mentioned this pull request

Reloader support for CronJobs #452

Open

jvstein mentioned this pull request

Add permissions on CronJob objects #541

Closed

This was referenced Oct 9, 2023

[Question] Is there some official documentation on using Reloader with a Cron Job #542

Closed

[Question] Official documentation on using Reloader with a Cron Job ? #543

Open

ChristianCiach mentioned this pull request

Add OwnerReference to generated Jobs #865

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet