[STK-322] Initial implementation #1

faizanahmad055 · 2018-07-10T08:50:43Z

No description provided.

stakater-user · 2018-07-10T08:53:49Z

@faizanahmad055 Yikes! You better fix it before anyone else finds out! Build 1 has Failed!

stakater-user · 2018-07-10T09:05:25Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-2

stakater-user · 2018-07-10T09:43:42Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-3

stakater-user · 2018-07-10T10:24:29Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-4

stakater-user · 2018-07-10T11:03:02Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-5

golangci · 2018-07-10T12:41:52Z

main.go

+		os.Exit(1)
+	}
+	os.Exit(0)
+}


File is not goimports-ed

golangci · 2018-07-10T12:41:52Z

internal/pkg/app/app.go

+func Run() error {
+	cmd := cmd.NewReloaderCommand()
+	return cmd.Execute()
+}


File is not goimports-ed

golangci · 2018-07-10T12:41:52Z

internal/pkg/cmd/reloader.go

+	"github.com/stakater/Reloader/internal/pkg/controller"
+	"github.com/stakater/Reloader/pkg/kube"
+	"github.com/sirupsen/logrus"
+)


File is not goimports-ed

golangci · 2018-07-10T12:41:53Z

pkg/kube/client.go

+	}
+	//If file exists so use that config settings
+	if _, err := os.Stat(kubeconfigPath); err == nil {
+		config, err = clientcmd.BuildConfigFromFlags("", kubeconfigPath)


ineffectual assignment to err

golangci · 2018-07-10T12:41:53Z

pkg/kube/client.go

+	if _, err := os.Stat(kubeconfigPath); err == nil {
+		config, err = clientcmd.BuildConfigFromFlags("", kubeconfigPath)
+	} else { //Use Incluster Configuration
+		config, err = rest.InClusterConfig()


ineffectual assignment to err

golangci · 2018-07-10T12:41:53Z

internal/pkg/controller/controller.go

+)
+
+const (
+	updateOnChangeAnnotation = "reloader.stakater.com.io/update-on-change"


updateOnChangeAnnotation is unused

golangci · 2018-07-10T12:41:53Z

internal/pkg/controller/controller.go

+type Event struct {
+	key          string
+	eventType    string
+	namespace    string


namespace is unused

We won't be needing the namespace in the event. This seems to be a direct copy from chowkidar. Please don't copy paste blindly. Try to understand how reloader should work and write code based on that yourself.

golangci · 2018-07-10T12:41:53Z

internal/pkg/controller/controller.go

+	key          string
+	eventType    string
+	namespace    string
+	resourceType string


resourceType is unused

Again, I don't know if this can be used in the future in Reloader

golangci · 2018-07-10T15:09:47Z

internal/pkg/controller/controller_test.go

+
+var (
+	client, _     = kube.GetClient()
+	configmapNamePrefix = "testconfigmap-reloader"


configmapNamePrefix is unused

golangci · 2018-07-10T15:09:47Z

internal/pkg/controller/controller_test.go

+	letters       = []rune("abcdefghijklmnopqrstuvwxyz")
+)
+
+func randSeq(n int) string {


randSeq is unused

golangci · 2018-07-10T15:09:47Z

internal/pkg/controller/controller_test.go

+	time.Sleep(15 * time.Second)
+}*/
+
+func initConfigmap(namespace string, configmapName string) *v1.ConfigMap {


initConfigmap is unused

golangci · 2018-07-10T15:09:47Z

internal/pkg/controller/controller_test.go

+	}
+}
+
+func updateConfigmap(namespace string, configmapName string) *v1.ConfigMap {


updateConfigmap is unused

golangci · 2018-07-10T15:09:48Z

internal/pkg/actions/action.go

+	configMapName := oldObj.(*v1.ConfigMap).Name
+	configMapVersion := convertConfigMapToToken(oldObj.(*v1.ConfigMap))
+
+	deployments, err := client.Apps().Deployments(ns).List(meta_v1.ListOptions{})


client.Apps is deprecated: please explicitly pick a version if possible.

golangci · 2018-07-10T15:09:48Z

internal/pkg/actions/action.go

+				updateContainers(containers, annotationValue, configMapVersion)
+
+				// update the deployment
+				_, err := client.Apps().Deployments(ns).Update(&d)


client.Apps is deprecated: please explicitly pick a version if possible.

golangci · 2018-07-10T15:09:48Z

internal/pkg/actions/action.go

+	for _, d := range deployments.Items {
+		containers := d.Spec.Template.Spec.Containers
+		// match deployments with the correct annotation
+		annotationValue, _ := d.ObjectMeta.Annotations[updateOnChangeAnnotation]


should write annotationValue := d.ObjectMeta.Annotations[updateOnChangeAnnotation] instead of annotationValue, _ := d.ObjectMeta.Annotations[updateOnChangeAnnotation]

golangci · 2018-07-10T15:09:48Z

internal/pkg/controller/controller_test.go

+var (
+	client, _     = kube.GetClient()
+	configmapNamePrefix = "testconfigmap-reloader"
+	letters       = []rune("abcdefghijklmnopqrstuvwxyz")


var letters is unused

stakater-user · 2018-07-10T15:16:38Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-6

golangci · 2018-07-11T10:48:51Z

internal/pkg/controller/controller.go

+	configMapName := oldObj.(*v1.ConfigMap).Name
+	configMapVersion := convertConfigMapToToken(oldObj.(*v1.ConfigMap))
+
+	deployments, err := client.Apps().Deployments(ns).List(meta_v1.ListOptions{})


client.Apps is deprecated: please explicitly pick a version if possible.

This shouldn't just be deployments, do something like

rollingUpgradeResource(resourceType.Deployment) rollingUpgradeResource(resourceType.StatefulSet) rollingUpgradeResource(resourceType.DaemonSet)

It's just an idea. Think on how you can make it generic for all type of resources

golangci · 2018-07-11T10:48:51Z

internal/pkg/controller/controller.go

+				updateContainers(containers, annotationValue, configMapVersion)
+
+				// update the deployment
+				_, err := client.Apps().Deployments(ns).Update(&d)


client.Apps is deprecated: please explicitly pick a version if possible.

golangci · 2018-07-11T10:48:51Z

internal/pkg/controller/controller.go

+	for _, d := range deployments.Items {
+		containers := d.Spec.Template.Spec.Containers
+		// match deployments with the correct annotation
+		annotationValue, _ := d.ObjectMeta.Annotations[updateOnChangeAnnotation]


should write annotationValue := d.ObjectMeta.Annotations[updateOnChangeAnnotation] instead of annotationValue, _ := d.ObjectMeta.Annotations[updateOnChangeAnnotation]

stakater-user · 2018-07-11T11:03:35Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-7

waseem-h

Based on what I've seen in the PR, here are a few comments

Don't copy paste stuff from Chowkidar or ConfigMapController. I've seen rollingUpgradeDeployments, updateContainers, convertToEnvVarName, convertConfigMapToToken methods which are copied from CMC and I don't think that is the perfect way of doing things. The logic can be improved and rewritten in our way
Use VS Code for GO Projects since its go extension takes care of all the linting and formatting etc
Don't add any new functionality to this PR. Just make sure that you're able to get configmaps and secrets in the create and update methods. And write test cases for that. Once that is merged, then proceed towards the next step
Use your own logic wherever possible. I've seen comments from Chowkidar which were pods specific and are present here as well

waseem-h · 2018-07-11T10:59:17Z

deployments/kubernetes/chart/reloader/templates/deployment.yaml

+  template:
+    metadata:
+      annotations:
+        configmap.fabric8.io/update-on-change: {{ template "reloader-name" . }}


Why is this here? Is it needed for reloader? And this seems to be for the old cmc

waseem-h · 2018-07-11T10:59:58Z

README.md

We have a specific format for our readme's. This is just copied from cmc's repo

waseem-h · 2018-07-11T11:01:18Z

deployments/kubernetes/chart/reloader/templates/rbac.yaml

+  name: {{ template "reloader-name" . }}
+---
+apiVersion: rbac.authorization.k8s.io/v1beta1
+kind: ClusterRole


Do we need a cluster role? Isn't this supposed to run in the namespaces we want sir @rasheedamir ? I think we should restrict RBAC's to namespace level

We've decided that the controller should only be able to run in 1 namespace that is specified in the env variable. Once that is done, we can easily implement all-namespace support keeping in mind the performance of the controller

waseem-h · 2018-07-11T11:01:47Z

glide.yaml

+- package: k8s.io/client-go
+  version: 5.0.0
+- package: github.com/spf13/cobra
+  version: ef82de70bb3f60c65fb8eebacbb2d122ef517385


Use version numbers instead of git sha

waseem-h · 2018-07-11T11:03:40Z

internal/pkg/controller/controller.go

+
+const (
+	updateOnChangeAnnotation = "reloader.stakater.com/update-on-change"
+	// AllNamespaces as our controller will be looking for events in all namespaces


We don't need this

waseem-h · 2018-07-11T11:45:02Z

internal/pkg/controller/controller_test.go

+)
+
+var (
+	client, _     = kube.GetClient()


Without checking error is a bad practice. Make sure there's no error or there's no point in going forward to the tests

waseem-h · 2018-07-11T11:46:29Z

internal/pkg/controller/controller_test.go

+	return string(b)
+}
+
+// Creating a Controller for Updating Pod with Default Action without Resources so messages printed


This looks copy pasted

waseem-h · 2018-07-11T11:47:41Z

internal/pkg/controller/controller_test.go

+	time.Sleep(10 * time.Second)
+
+	logrus.Infof("Updating Configmap %q.\n", configmap.GetObjectMeta().GetName())
+	retryErr := retry.RetryOnConflict(retry.DefaultRetry, func() error {


I don't see why this is needed. Explain please

waseem-h · 2018-07-11T11:48:35Z

internal/pkg/controller/controller_test.go

+}
+
+func updateConfigmap(namespace string, configmapName string) *v1.ConfigMap {
+	return &v1.ConfigMap{


Updating the label of the configmap shouldn't restart the pods. So update the data in the configmap

waseem-h · 2018-07-11T11:50:00Z

pkg/kube/resourcemapper.go

+)
+
+// MapToRuntimeObject maps the resource type string to the actual resource
+func MapToRuntimeObject(resourceType string) runtime.Object {


We don't need this since we don't have a default resource type

stakater-user · 2018-07-11T12:00:54Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-8

golangci · 2018-07-11T15:21:48Z

internal/pkg/cmd/reloader.go

+	"github.com/stakater/Reloader/internal/pkg/controller"
+	"github.com/stakater/Reloader/pkg/kube"
+	"github.com/sirupsen/logrus"
+	"k8s.io/apimachinery/pkg/apis/meta/v1"


File is not goimports-ed

golangci · 2018-07-11T15:21:48Z

internal/pkg/controller/controller_test.go

+
+var (
+	client, err     = kube.GetClient()
+	configmapNamePrefix = "testconfigmap-reloader"


configmapNamePrefix is unused

golangci · 2018-07-12T09:37:03Z

internal/pkg/controller/controller_test.go

+	// TODO: Add functionality to verify reloader functionality here
+
+	if updateErr != nil {
+		controller.client.CoreV1().ConfigMaps(namespace).Delete(configmapName, &metav1.DeleteOptions{})


Error return value of (github.com/stakater/Reloader/vendor/k8s.io/client-go/kubernetes/typed/core/v1.ConfigMapInterface).Delete is not checked

golangci · 2018-07-12T09:37:03Z

internal/pkg/controller/controller_test.go

+	}
+	time.Sleep(10 * time.Second)
+	logrus.Infof("Deleting Configmap %q.\n", configmap.GetObjectMeta().GetName())
+	controller.client.CoreV1().ConfigMaps(namespace).Delete(configmapName, &metav1.DeleteOptions{})


Error return value of (github.com/stakater/Reloader/vendor/k8s.io/client-go/kubernetes/typed/core/v1.ConfigMapInterface).Delete is not checked

golangci · 2018-07-12T09:37:03Z

internal/pkg/controller/controller_test.go

+)
+
+var (
+	client, err     = kube.GetClient()


err is unused

stakater-user · 2018-07-12T09:43:31Z

@faizanahmad055 Yikes! You better fix it before anyone else finds out! Build 9 has Failed!

stakater-user · 2018-07-13T11:55:58Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-15

… into initial-implementation

stakater-user · 2018-07-13T12:14:34Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-16

waseem-h · 2018-07-13T12:17:23Z

internal/pkg/cmd/reloader.go

+
+// NewReloaderCommand starts the reloader controller
+func NewReloaderCommand() *cobra.Command {
+	cmds := &cobra.Command{


This should be cmd

waseem-h · 2018-07-13T12:18:44Z

internal/pkg/controller/controller.go

+	indexer   cache.Indexer
+	queue     workqueue.RateLimitingInterface
+	informer  cache.Controller
+	resource  string


This shouldn't be a part of controller. Its just used for initializing

waseem-h · 2018-07-13T12:19:25Z

internal/pkg/controller/controller.go

+
+	indexer, informer := cache.NewIndexerInformer(listWatcher, kube.ResourceMap[resource], 0, cache.ResourceEventHandlerFuncs{
+		AddFunc:    c.Add,
+		UpdateFunc: c.Update,


Add delete func with log

waseem-h · 2018-07-13T12:28:27Z

internal/pkg/controller/controller.go

+)
+
+// ResourceUpdated contains new or updated objects
+type ResourceUpdated struct {


Rename it to ResourceHandler
Move it to internal/pkg/handler/resourcehandler.go
Call handler.Handle() on the item

Have 2 resouce handlers

ResourceCreatedHandler

ResourceUpdatedHandler

Just log items in both their handle functions

Names should be newResource and oldResource

waseem-h · 2018-07-13T12:30:24Z

internal/pkg/controller/controller.go

+
+func (c *Controller) processNextItem() bool {
+	// Wait until there is a new item in the working queue
+	resourceUpdated, quit := c.queue.Get()


Change the name based on the struct

waseem-h · 2018-07-13T12:31:37Z

internal/pkg/controller/controller.go

+	defer c.queue.Done(resourceUpdated)
+
+	// Invoke the method containing the business logic
+	err := c.takeAction(resourceUpdated.(ResourceUpdated))


just call resourceHandler.Handle() method and remove the method below

waseem-h · 2018-07-13T12:32:22Z

internal/pkg/controller/controller_test.go

+	_, err = configmapClient.Create(initConfigmap(namespace, configmapName))
+	if err != nil {
+		logrus.Infof("Error detected %s.\n", err)
+		panic(err)


Don't use panic anywhere in code. Use logrus fatal methods

waseem-h · 2018-07-13T12:32:52Z

internal/pkg/controller/controller_test.go

+	if error != nil {
+		panic(error)
+	}
+	//time.Sleep(10 * time.Second)


Remove commented code if its not necessary

stakater-user · 2018-07-13T14:10:18Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-17

waseem-h · 2018-07-16T08:00:21Z

internal/pkg/controller/controller.go

+	})
+}
+
+// Delete function to add an 'update' event to the queue in case of deleting a resource


Fix typo in the comment

waseem-h · 2018-07-16T08:02:05Z

internal/pkg/controller/controller_test.go

+)
+
+var (
+	client, _           = kube.GetClient()


Either properly check that the client is successfully created if it's global, or created it in each test and check for error

waseem-h · 2018-07-16T08:03:54Z

internal/pkg/handler/resourcehandler.go

+
+// ResourceCreatedHandler contains new objects
+type ResourceCreatedHandler struct {
+	NewResource interface{}


Change this to just Resource

waseem-h · 2018-07-16T08:04:24Z

internal/pkg/handler/resourcehandler.go

@@ -0,0 +1,58 @@
+package handler


Rename this to handler.go

waseem-h · 2018-07-16T08:04:52Z

internal/pkg/handler/resourcehandler.go

+}
+
+// ResourceCreatedHandler contains new objects
+type ResourceCreatedHandler struct {


Refactor these created and updated handlers to separate files. created-handler.go, updated-handler.go

stakater-user · 2018-07-16T08:45:27Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-18

waseem-h · 2018-07-16T09:00:03Z

internal/pkg/controller/controller_test.go

+func TestControllerForUpdatingConfigmapShouldUpdateDeployment(t *testing.T) {
+	client, err := kube.GetClient()
+	if err != nil {
+		logrus.Infof("Unable to create Kubernetes client error = %v", err)


Error logs shouldn't be treated as info

waseem-h · 2018-07-16T09:00:57Z

internal/pkg/handler/handler.go

+}
+
+// Handle processes the newly created resource
+func (r ResourceCreatedHandler) Handle() error {


This is related to created handler so it needs to be moved to that file

waseem-h · 2018-07-16T09:01:03Z

internal/pkg/handler/handler.go

+}
+
+// Handle processes the updated resource
+func (r ResourceUpdatedHandler) Handle() error {


This is related to updated handler so it needs to be moved to that file

stakater-user · 2018-07-16T09:31:21Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-19

hazim1093

Please fix usage of log severity throughout the code

hazim1093 · 2018-07-16T12:05:44Z

build/package/Dockerfile

@@ -0,0 +1,5 @@
+FROM scratch


There shouldn't be 3 dockerfiles, Verify and remove the unused one, it will probably be this one

hazim1093 · 2018-07-16T12:07:27Z

glide.yaml

+- package: github.com/spf13/pflag
+  version: 1.0.1
+- package: github.com/sirupsen/logrus
+  version: ~1.0.3


What does ~ specify? I think we don't need it and should use specific version

hazim1093 · 2018-07-16T12:09:00Z

internal/pkg/cmd/reloader.go

+	currentNamespace := os.Getenv("KUBERNETES_NAMESPACE")
+	if len(currentNamespace) == 0 {
+		currentNamespace = v1.NamespaceAll
+		logrus.Infof("Warning: KUBERNETES_NAMESPACE is unset, will detect changes in all namespaces.")


Log this as a warning, we won't need to specify "Warning" text then

hazim1093 · 2018-07-16T12:12:29Z

internal/pkg/controller/controller.go

+// Delete function to add an object to the queue in case of deleting a resource
+func (c *Controller) Delete(old interface{}) {
+	// TODO Added this function for future usecase
+	logrus.Infof("Deleted resource has been added to queue")


Make the comment text clearer that Delete resource does not do anything for now

hazim1093 · 2018-07-16T12:16:46Z

internal/pkg/controller/controller.go

+
+	// This controller retries 5 times if something goes wrong. After that, it stops trying.
+	if c.queue.NumRequeues(key) < 5 {
+		logrus.Infof("Error syncing events %v: %v", key, err)


Log this as error if its an error instead of info

hazim1093 · 2018-07-16T14:57:12Z

internal/pkg/controller/controller_test.go

+	if updateErr != nil {
+		err := controller.client.CoreV1().Secrets(namespace).Delete(secretName, &metav1.DeleteOptions{})
+		if err != nil {
+			logrus.Infof("Error while deleting the secret %v", err)


hazim1093 · 2018-07-16T14:57:21Z

internal/pkg/controller/controller_test.go

+		if err != nil {
+			logrus.Infof("Error while deleting the secret %v", err)
+		}
+		logrus.Infof("Error while deleting the secret %v", err)


hazim1093 · 2018-07-16T14:57:30Z

internal/pkg/controller/controller_test.go

+	logrus.Infof("Deleting Secret %q.\n", secretName)
+	err = controller.client.CoreV1().Secrets(namespace).Delete(secretName, &metav1.DeleteOptions{})
+	if err != nil {
+		logrus.Infof("Error while deleting the secret %v", err)


hazim1093 · 2018-07-16T14:58:20Z

internal/pkg/handler/created-handler.go

+		} else if _, ok := r.Resource.(*v1.Secret); ok {
+			logrus.Infof("Performing 'Added' action for resource of type 'secret'")
+		} else {
+			logrus.Infof("Invalid resource")


Is this info, warn or error?

hazim1093 · 2018-07-16T14:58:35Z

internal/pkg/handler/updated-handler.go

+		} else if _, ok := r.Resource.(*v1.Secret); ok {
+			logrus.Infof("Performing 'Updated' action for resource of type 'secret'")
+		} else {
+			logrus.Infof("Invalid resource")


info warn or error?

Please elaborate the log message

stakater-user · 2018-07-17T08:16:27Z

@faizanahmad055 Image is available for testing. docker pull stakater/reloader:PR-1-20

* Initial * State * State * Revert unintentional change * Update * Update * Fix tests * Support patching for both reload strategies * rolling_upgrade tests * Update * More tests * Remove unnecessary stuff

faizanahmad055 added 5 commits July 6, 2018 20:26

Added initial implementation to detect changes

5920890

Add build files

ee079a4

Remove duplicate readme

ae4fabc

Update controller to remove unnecessary code

b79f90e

Add chart in Reloader

acc0271

faizanahmad055 requested a review from waseem-h July 10, 2018 08:50

Remove unused config from reloader

0004271

Update rbac in reloader

c05ef23

Fix namespace issue in rbac

dcc11b0

Append reloader to templates

9281256

golangci reviewed Jul 10, 2018

View reviewed changes

Implement actions for configmap upgrade

a2af49c

golangci reviewed Jul 10, 2018

View reviewed changes

Add action methods in controller

7944eb4

golangci reviewed Jul 11, 2018

View reviewed changes

Add temporary conidtion for configmaps

ade1e48

waseem-h suggested changes Jul 11, 2018

View reviewed changes

Implement PR-1 review comments

848745f

golangci reviewed Jul 11, 2018

View reviewed changes

Implement PR-1 review comments

9376276

golangci reviewed Jul 12, 2018

View reviewed changes

waseem-h and others added 4 commits July 13, 2018 17:05

Fix controller_test format

6d821ca

Merge branch 'initial-implementation' of github.com:stakater/Reloader…

c3135ce

… into initial-implementation

Implement golangci comments

c58efd1

Implement golangci comments

5823152

waseem-h suggested changes Jul 13, 2018

View reviewed changes

Add resource handler to handle rolling updates

14f9570

waseem-h reviewed Jul 16, 2018

View reviewed changes

internal/pkg/handler/resourcehandler.go Outdated

@@ -0,0 +1,58 @@

package handler

Copy link

Contributor

waseem-h Jul 16, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename this to handler.go

waseem-h reviewed Jul 16, 2018

View reviewed changes

Implement PR-1 review comments

0f78a15

waseem-h reviewed Jul 16, 2018

View reviewed changes

Implement PR-1 review comments

44341ff

waseem-h approved these changes Jul 16, 2018

View reviewed changes

hazim1093 requested changes Jul 16, 2018

View reviewed changes

Fix logrus usage

21fec1c

hazim1093 approved these changes Jul 17, 2018

View reviewed changes

hazim1093 merged commit 0372dee into master Jul 17, 2018

hazim1093 deleted the initial-implementation branch July 17, 2018 08:50

videlov referenced this pull request in sapcc/Reloader Apr 23, 2025

Support for resource patching with retries (#1)

d40fb7b

Uh oh!

[STK-322] Initial implementation #1

[STK-322] Initial implementation #1

Uh oh!

Conversation

faizanahmad055 commented Jul 10, 2018

Uh oh!

stakater-user commented Jul 10, 2018

Uh oh!

stakater-user commented Jul 10, 2018

Uh oh!

stakater-user commented Jul 10, 2018

Uh oh!

stakater-user commented Jul 10, 2018

Uh oh!

stakater-user commented Jul 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stakater-user commented Jul 10, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

stakater-user commented Jul 11, 2018

Uh oh!

waseem-h left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!