[BUG] Deployment.apps "reloader-reloader" is invalid: spec.template.metadata.labels #897
Description
Describe the bug
Unable to deploy reloader using the official helm chart.
To Reproduce
Checkout the master branch and run
helm -n reloader upgrade --install reloader ./charts/reloader -f ./values.yml
Error: UPGRADE FAILED: failed to create resource: Deployment.apps "reloader-reloader" is invalid: spec.template.metadata.labels: Invalid value: map[string]string{"app.kubernetes.io/instance":"reloader", "app.kubernetes.io/managed-by":"Helm", "app.kubernetes.io/name":"reloader", "app.kubernetes.io/version":"v1.3.0", "group":"com.stakater.platform", "helm.sh/chart":"reloader-2.0.0", "provider":"stakater", "version":"v1.3.0"}: `selector` does not match template `labels`
Expected behavior
Should have deployed without errors.
Solution might be to use reloader-fullname for the labels: https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/templates/_helpers.tpl#L31 or use reloader-name in https://github.com/stakater/Reloader/blob/master/deployments/kubernetes/chart/reloader/templates/deployment.yaml#L28.
Happy to make this a PR
Screenshots
If applicable, add screenshots to help explain your problem.
Environment
- Operator Version:
- Kubernetes/OpenShift Version:
Additional context
Add any other context about the problem here.