Skip to content

Conversation

mmorel-35
Copy link
Contributor

Description

Enables and fixes unnecessaryDefer rule from go-critic

Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
@mmorel-35 mmorel-35 marked this pull request as ready for review July 11, 2025 18:46
@mmorel-35 mmorel-35 requested a review from rhybrillou as a code owner July 11, 2025 18:46
Copy link

codecov bot commented Jul 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.66%. Comparing base (dbd7529) to head (df14c5a).
Report is 137 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #984       +/-   ##
===========================================
- Coverage   62.36%   28.66%   -33.70%     
===========================================
  Files         197      209       +12     
  Lines        4854     5947     +1093     
===========================================
- Hits         3027     1705     -1322     
- Misses       1439     4126     +2687     
+ Partials      388      116      -272     
Flag Coverage Δ
unit 28.66% <ø> (-33.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rhybrillou rhybrillou merged commit 92399ac into stackrox:main Jul 14, 2025
6 of 7 checks passed
@mmorel-35 mmorel-35 deleted the gocritic/unnecessaryDefer branch July 14, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants