Add error if num_chains is supplied to non-HMC algorithm #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This does cover some cases, but I think there are still a few that are not caught by this (particularly running fixed_param still didn't error in my case). So it's an improvement to the status quo so I am good with merging this. |
|
Hm, it raises an error if you supply |
|
That detection happens here: https://github.com/stan-dev/cmdstan/blob/develop/src/cmdstan/command.hpp#L693 |
|
I’d rather we just consider #1054 again, but otherwise we should add an error there. The message will need to be very careful though, since it might be that the user didn’t specify anything incompatible |
|
@rok-cesnovar updated to also error in that case with a longer error |
rok-cesnovar
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/testSummary:
Adds an error thrown if
num_chainswas specified but the algorithm is not HMC with adaptation.Intended Effect:
Closes #1057
How to Verify:
Try to run with
adapt engaged=0 num_chains=2ornum_chains=2 algorithm=fixed_paramand observe an error is thrownCopyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: