feat: add option to restrict the default resolver to IPv4 or IPv6 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rs
reviewed
Aug 2, 2023
dnscache.go
Outdated
|
|
||
| func (d *defaultResolverWithTrace) LookupHost(ctx context.Context, host string) (addrs []string, err error) { | ||
| // `net.Resolver#LookupHost` does not cause invocation of `net.Resolver#lookupIPAddr`, therefore the `DNSStart` and `DNSDone` tracing hooks | ||
| // built into the stdlib are never called. `LookupIP`, despite it's name, can also be used to lookup a hostname but does cause these hooks to be | ||
| // triggered. The format of the reponse is different, therefore it needs this thin wrapper converting it. | ||
| rawIPs, err := net.DefaultResolver.LookupIP(ctx, "ip", host) | ||
| rawIPs, err := net.DefaultResolver.LookupIP(ctx, d.ipVersion, host) |
There was a problem hiding this comment.
You need to handle the case where d.ipVersion is "".
There was a problem hiding this comment.
I would argue that this is not necessary as the only way to use this defaultResolverWithTrace (from outside this lib) is by either using the defaultResolver or by retreiving a defaultResolverWithTrace from the functions NewResolverOnlyV4 and NewResolverOnlyV6. In all 3 cases there is alreade the ipVersion set.
There was a problem hiding this comment.
Sure but code evolve over time and this situation could change.
There was a problem hiding this comment.
ok i've added that if ipVersion is not ip, ip4 or ip6 then ip will be used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to restrict the default Resolver to IPv4 or IPv6 only. Its useful when the targets are only reachable by e.g. IPv4 anyway and one wants to reduce the load on the DNS Server