Skip to content

fix minor unreachable code caused by t.Fatal #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2022
Merged

fix minor unreachable code caused by t.Fatal #1060

merged 1 commit into from
Aug 9, 2022

Conversation

Abirdcfly
Copy link
Contributor

https://pkg.go.dev/testing#T.Fatalf

Fatalf is equivalent to Logf followed by FailNow.

https://pkg.go.dev/testing#T.FailNow

FailNow marks the function as having failed and stops its execution by calling runtime.Goexit (which then runs all deferred calls in the current goroutine).

@Abirdcfly
fix minor unreachable code caused by t.Fatal
1b033f3 
Signed-off-by: Abirdcfly <fp544037857@gmail.com>
@otoolep
Copy link
Member

otoolep commented Aug 9, 2022

Thank you for your contribution.

@otoolep otoolep merged commit 96f789b into rqlite:master Aug 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abirdcfly @otoolep