Skip to content

BUG: super fast crop zoom call fix #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 26, 2022
Merged

BUG: super fast crop zoom call fix #154

merged 3 commits into from
Apr 26, 2022

Conversation

AhmetCanSolak
Copy link
Collaborator

This PR fixes a bug introduced in #152. Currently, we are passing downscaling factors to all dimensions of any given image of interest in the

aydin/aydin/util/crop/sf_rep_crop.py

Line 52 in 66fd9db

image_d = zoom(image, zoom=zoom_per_axis, prefilter=False, order=0)
and this is causing division by zero with the dimensions of length-1.

@AhmetCanSolak AhmetCanSolak added the bug Something isn't working label Apr 26, 2022
@AhmetCanSolak AhmetCanSolak self-assigned this Apr 26, 2022
@AhmetCanSolak AhmetCanSolak merged commit 409e7e6 into royerlab:master Apr 26, 2022
@AhmetCanSolak AhmetCanSolak deleted the sf-crop-zoom-call-fix branch April 28, 2022 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@AhmetCanSolak AhmetCanSolak

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@AhmetCanSolak