Skip to content

feat: import address names CSV #9050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 10, 2024
Merged

feat: import address names CSV #9050

merged 2 commits into from
Dec 10, 2024

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Dec 10, 2024 •
edited
Loading

Closes #7144

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@codecov Codecov
Copy link

codecov bot commented Dec 10, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 26.89076% with 174 lines in your changes missing coverage. Please review.

Project coverage is 54.85%. Comparing base (60ae105) to head (af5fd24).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...address-book-manager/AddressBookManagementMore.vue 0.00% 102 Missing ⚠️
...omponents/accounts/AccountBalancesExportImport.vue 0.00% 68 Missing ⚠️
...nts/address-book-manager/AddressBookManagement.vue 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #9050      +/-   ##
===========================================
- Coverage    56.04%   54.85%   -1.20%     
===========================================
  Files         1897     1893       -4     
  Lines       134547   140437    +5890     
  Branches     18113    17277     -836     
===========================================
+ Hits         75413    77042    +1629     
- Misses       56307    60568    +4261     
  Partials      2827     2827
Flag Coverage Δ
frontend_integration 55.67% <ø> (-0.27%) ⬇️
frontend_unit 28.27% <26.89%> (+0.56%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi force-pushed the import-address-names branch 3 times, most recently from ede97fa to 3fa0c49 Compare December 10, 2024 10:28
@lukicenturi lukicenturi force-pushed the import-address-names branch 2 times, most recently from f0a9fe7 to efd0f99 Compare December 10, 2024 13:36
kelsos
kelsos approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thank you :)

@kelsos kelsos merged commit 243e970 into rotki:develop Dec 10, 2024
16 checks passed
@kelsos kelsos deleted the import-address-names branch December 10, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Figure out way to import multiple addresses to the address book
2 participants
@lukicenturi @kelsos