resolve .argent.xyz domains #8987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## bugfixes #8987 +/- ##
=============================================
+ Coverage 58.51% 80.98% +22.46%
=============================================
Files 1795 808 -987
Lines 125807 59920 -65887
Branches 16386 10778 -5608
=============================================
- Hits 73614 48525 -25089
+ Misses 49560 8686 -40874
- Partials 2633 2709 +76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LefterisJP
reviewed
Nov 30, 2024
rotkehlchen/chain/evm/constants.py
Outdated
| @@ -39,3 +39,4 @@ | |||
|
|
|||
| # uniswap like merkle distributor claimed signature | |||
| MERKLE_CLAIM: Final = b'N\xc9\x0e\x96U\x19\xd9&\x81&tg\xf7u\xad\xa5\xbd!J\xa9,\r\xc9=\x90\xa5\xe8\x80\xce\x9e\xd0&' # noqa: E501 | |||
| VALID_ENS_EXTENSIONS: Final = ('.eth', '.argent.xyz') # extensions compatible with the ENS resolution contract # noqa: E501 | |||
There was a problem hiding this comment.
Why only those? Isn't literally almost any TLD okay? https://docs.ens.domains/dns/tlds
0ae449d to
e9cdc5e
Compare
LefterisJP
reviewed
Dec 2, 2024
allow the api to use argent domains in addtion to .eth domains. Closes rotki#8981
|
rotki/test-caching/tree/argent was successfully merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allow the api to use argent domains in addtion to .eth domains.
Closes #8981