Skip to content

Conversation

prettyirrelevant
Copy link
Contributor

Closes #7406

Copy link

codecov bot commented Nov 29, 2024

Codecov Report

Attention: Patch coverage is 60.95890% with 57 lines in your changes missing coverage. Please review.

Project coverage is 55.73%. Comparing base (8197dd4) to head (59131ca).
Report is 2 commits behind head on develop.

Files with missing lines Patch % Lines
...tkehlchen/chain/evm/decoding/aura_finance/utils.py 41.37% 32 Missing and 2 partials ⚠️
...hlchen/chain/evm/decoding/aura_finance/balances.py 77.35% 9 Missing and 3 partials ⚠️
rotkehlchen/tasks/manager.py 50.00% 4 Missing ⚠️
.../chain/ethereum/modules/aura_finance/accountant.py 70.00% 2 Missing and 1 partial ⚠️
rotkehlchen/chain/evm/decoding/utils.py 60.00% 1 Missing and 1 partial ⚠️
rotkehlchen/inquirer.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop    #8974     +/-   ##
==========================================
  Coverage    55.73%   55.73%             
==========================================
  Files         1879     1879             
  Lines       133755   135964   +2209     
  Branches     16708    16816    +108     
==========================================
+ Hits         74543    75777   +1234     
- Misses       56401    57370    +969     
- Partials      2811     2817      +6     
Flag Coverage Δ
backend 80.78% <60.95%> (-0.07%) ⬇️
frontend_integration 55.69% <ø> (-0.18%) ⬇️
frontend_unit 28.61% <ø> (+0.93%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@prettyirrelevant prettyirrelevant force-pushed the aura-finance-balances branch 2 times, most recently from 2373233 to e64dd40 Compare November 29, 2024 15:39
@prettyirrelevant prettyirrelevant force-pushed the aura-finance-balances branch 2 times, most recently from 54f8cbf to 7bc8ad8 Compare December 2, 2024 12:19
Comment on lines -43 to -51
def _update_cache_timestamp(count: int | None = None) -> None:
with GlobalDBHandler().conn.write_ctx() as write_cursor:
globaldb_set_unique_cache_value(
write_cursor=write_cursor,
key_parts=[CacheType.MORPHO_VAULTS],
value=str(count) if count is not None else '0',
)


Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead code removal.

@prettyirrelevant prettyirrelevant force-pushed the aura-finance-balances branch 5 times, most recently from 44bc13e to 90a0b16 Compare December 2, 2024 14:02
Copy link
Member

@LefterisJP LefterisJP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LefterisJP LefterisJP merged commit 598fcc8 into rotki:develop Dec 2, 2024
18 checks passed
@rotkibot
Copy link

rotkibot commented Dec 2, 2024

rotki/test-caching#58 was successfully merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Aura pools in gnosis chain (and more?)
3 participants