Skip to content

feat: blockchain balances filter by chains #8961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

feat: blockchain balances filter by chains #8961

merged 1 commit into from
Nov 28, 2024

Conversation

lukicenturi
Copy link
Contributor

@lukicenturi lukicenturi commented Nov 27, 2024 •
edited
Loading

Closes #8929
Do you think I should make this against develop instead?

Checklist

  • The PR modified the frontend, and updated the user guide to reflect the changes.

@lukicenturi lukicenturi force-pushed the blockchain-balances-filter branch from 6ba4f45 to f5fca4c Compare November 27, 2024 14:30
@codecov Codecov
Copy link

codecov bot commented Nov 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 45.68528% with 107 lines in your changes missing coverage. Please review.

Project coverage is 50.42%. Comparing base (ed34c4d) to head (444a880).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
...tend/app/src/pages/balances/blockchain/[[tab]].vue 10.00% 36 Missing ⚠️
...rc/components/dashboard/VisibleColumnsSelector.vue 0.00% 32 Missing ⚠️
frontend/app/src/components/AssetBalances.vue 73.07% 21 Missing ⚠️
...liquity-provider/LiquidityProviderBalanceTable.vue 0.00% 5 Missing ⚠️
...src/components/accounts/blockchain/ChainSelect.vue 33.33% 4 Missing ⚠️
...p/src/components/dashboard/DashboardAssetTable.vue 20.00% 4 Missing ⚠️
...d/app/src/components/dashboard/NftBalanceTable.vue 0.00% 2 Missing ⚠️
...nts/address-book-manager/AddressBookManagement.vue 0.00% 1 Missing ⚠️
.../components/dashboard/DashboardExpandableTable.vue 0.00% 1 Missing ⚠️
frontend/app/src/utils/array.ts 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           develop    #8961       +/-   ##
============================================
- Coverage    56.18%   50.42%    -5.77%     
============================================
  Files          656     1872     +1216     
  Lines        18258   135460   +117202     
  Branches      3098    16757    +13659     
============================================
+ Hits         10259    68311    +58052     
- Misses        7999    64496    +56497     
- Partials         0     2653     +2653
Flag Coverage Δ
frontend_integration 56.26% <82.22%> (+0.26%) ⬆️
frontend_unit 28.63% <40.30%> (+0.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukicenturi lukicenturi force-pushed the blockchain-balances-filter branch from f5fca4c to 3709245 Compare November 27, 2024 14:45
@kelsos
Copy link
Member

kelsos commented Nov 27, 2024 •
edited
Loading

Closes #8929 Do you think I should make this against develop instead?

Checklist

* [ ]  The PR modified the frontend, and updated the [user guide](https://github.com/rotki/rotki/blob/develop/docs/usage_guide.rst) to reflect the changes.

Yes since it is a bit bigger for bugfixes I think we should better move it to develop

@lukicenturi lukicenturi force-pushed the blockchain-balances-filter branch from 3709245 to 77c3344 Compare November 28, 2024 06:05
@lukicenturi lukicenturi changed the base branch from bugfixes to develop November 28, 2024 06:06
@lukicenturi lukicenturi force-pushed the blockchain-balances-filter branch from 77c3344 to c66b594 Compare November 28, 2024 06:08
@lukicenturi lukicenturi force-pushed the blockchain-balances-filter branch from c66b594 to 444a880 Compare November 28, 2024 09:08
kelsos
kelsos approved these changes Nov 28, 2024
View reviewed changes
Copy link
Member

@kelsos kelsos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kelsos kelsos merged commit 6095f9b into rotki:develop Nov 28, 2024
16 checks passed
@kelsos kelsos deleted the blockchain-balances-filter branch November 28, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelsos kelsos kelsos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accounts & Balances section should show % of net value like dashboard
2 participants
@lukicenturi @kelsos