Skip to content

Error handling often overwrites errors already set #740

@hidmic

Description

@hidmic

Bug report

Required Info:

  • Operating System:
    • All Tier 1 platforms
  • Installation type:
    • From source
  • Version or commit hash:

Steps to reproduce issue

Run rcl tests locally:

colcon test --event-handlers=console_direct+ --packages-select rcl

Expected behavior

All tests pass and no error handling error (an overwrite) is reported via stderr.

Actual behavior

All tests pass but plenty error handling errors (overwrites) are reported.

Additional information

These overwrites are the result of either ignoring errors set by rcutils or rmw APIs or attempting to propagate them, which isn't necessarily bad practice if it weren't for the fact that all our libraries share the same global error state.

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions