-
Notifications
You must be signed in to change notification settings - Fork 127
Closed
Labels
enhancementNew feature or requestNew feature or requestin progressActively being worked on (Kanban column)Actively being worked on (Kanban column)
Description
Feature description
It was noticed in the addition of #266, that there was a performance hit, possibly due to the use of the regex
library. See #266 (comment) for a discussion.
A simple benchmark is timing the rcl graph tests before and after applying the change:
for i in {1..10}; do; /usr/bin/time -o time.txt -a --format "%E" build/rcl/test/test_graph__rmw_fastrtps_cpp; done
cat time.txt
On my machine,
before: 03.06 seconds
after: 04.28 seconds
Implementation considerations
We should try replacing the usage of regex
and cutting down on string copies (as suggested) to see if performance can be improved.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestin progressActively being worked on (Kanban column)Actively being worked on (Kanban column)