Skip to content

Conversation

hidmic
Copy link
Contributor

@hidmic hidmic commented Sep 21, 2020

Fix for regression introduced in #241. See https://ci.ros2.org/job/ci_linux/12374/testReport/.

Full CI (expensive, but just to be sure):

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Fix for regression introduced in #241.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
@hidmic hidmic requested a review from jacobperron September 21, 2020 23:09
Copy link
Member

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI.

Thanks!

@hidmic hidmic merged commit 5204835 into master Sep 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the hidmic/fix-take branch September 22, 2020 13:12
ahcorde pushed a commit that referenced this pull request Oct 9, 2020
Fix for regression introduced in #241.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
ahcorde pushed a commit that referenced this pull request Oct 15, 2020
Fix for regression introduced in #241.

Signed-off-by: Michel Hidalgo <michel@ekumenlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants