Skip to content

core/vm: implement EIP-2537 spec updates #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
May 21, 2025
Merged

core/vm: implement EIP-2537 spec updates #42

merged 9 commits into from
May 21, 2025

Conversation

sonhv0212
Copy link
Contributor

@sonhv0212 sonhv0212 commented Mar 18, 2025 •
edited
Loading

Description

This PR implements EIP-2537 spec updates and replaces the internal BLS12-381 package (fork of kilic) by gnark-crypto

Specs:

PRs:

minh-bq
minh-bq reviewed Mar 18, 2025
View reviewed changes
hao-phamSM
hao-phamSM approved these changes Apr 23, 2025
View reviewed changes
Copy link

@hao-phamSM hao-phamSM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sonhv0212 added 9 commits May 21, 2025 11:04
@sonhv0212
core/vm: add precompiled contracts, addresses Prague
395a212 
reference: ethereum/EIPs#8945
@sonhv0212
core/vm: remove redundant MUL precompiles in tests
68e7bd4 
reference: ethereum/EIPs#8945
@sonhv0212
params: adjust gas of BLS precompiled address
6abddc6 
References:
- ethereum/EIPs#9097
- ethereum/EIPs#9098
@sonhv0212
core/vm,params: update DiscountTable for Bls12381G1 and Bls12381G2
8a1d3bb 
reference: ethereum/EIPs#9116
@sonhv0212
core/vm: add subgroup checks for mulexp for G1/G2
a61f6b3 
Reference:
- PR: ethereum/go-ethereum#29637
- spec: ethereum/EIPs#8456
@sonhv0212
core/vm/testdata/precompiles: update precompile tests EIP-2537
c0b4d67
@sonhv0212
core/vm: fix wrong addresses of precompiled contracts Prague
3f3713a
@sonhv0212
core/vm: use gnark BLS12-381 instead of the older
4ab9ac4 
PR: ethereum/go-ethereum#29441
@sonhv0212
core/vm,tests/fuzzers/bls12381: Remove unused tests
560adb4
@sonhv0212 sonhv0212 merged commit 48d46c1 into ronin-chain:main May 21, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trantienduchn trantienduchn trantienduchn approved these changes

@hao-phamSM hao-phamSM hao-phamSM approved these changes

+2 more reviewers

@minh-bq minh-bq minh-bq approved these changes

@chiphamskymavis chiphamskymavis chiphamskymavis approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sonhv0212 @trantienduchn @minh-bq @chiphamskymavis @hao-phamSM