Removing depricated BitcoinHash crate
#240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
34 tasks
|
LGTM, many thanks for the fix! |
3a77785 to
27bf3a8
Compare
27bf3a8 to
af6ff09
Compare
|
With the new bitcoin crate 0.24 release this PR is ready for review & merge. I have rebased it + also moved from direct usage of bitcoin_hashes crate towards version cross-imported from bitcoin directly: this helps to avoid version conflicts between local and bitcoin structures. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version of
rust-bitcoinremoved traitBitcoinHash. This is not yet got to the crates, but is required for Signet support in #239, so I am adding this as a separate PR to be edited & merged after the new bitcoin crate version will be released to crates.ioPS. this PR includes bulk of changes from #238, pls ignore them (w/o these changes it would not compile)