Skip to content

[ROMM-2163] Fix excluding single roms without extensions #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

Conversation

gantoine
Copy link
Member

Description
Explain the changes or enhancements you are proposing with this pull request.

Fixes #2163

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@gantoine gantoine requested review from adamantike and Copilot August 12, 2025 22:19
Copy link

trunk-io bot commented Aug 12, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Fixes an issue with excluding single ROM files that don't have file extensions. The change modifies the exclusion logic to only exclude files when they have an extension that matches the excluded list, rather than excluding all files without extensions.

  • Updated exclusion condition to preserve files without extensions
  • Added case-insensitive comparison for extension matching

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

github-actions bot commented Aug 12, 2025

Test Results

548 tests   547 ✅  57s ⏱️
  1 suites    1 💤
  1 files      0 ❌

Results for commit 47e9138.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 12, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8755 6175 71% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/config/config_manager.py 46% 🟢
backend/handler/filesystem/base_handler.py 95% 🟢
TOTAL 70% 🟢

updated for commit: 47e9138 by action🐍

@gantoine gantoine merged commit 6b31a64 into master Aug 12, 2025
9 checks passed
@gantoine gantoine deleted the romm-2163 branch August 12, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Nintendo DSi ROMs with numeric names and no extension are not scanned correctly
2 participants