[ROMM-2247] Return early if cover write fails #2249
Conversation
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where cover image fetch failures were not properly handled by adding an early return when cover write operations fail due to transport errors.
- Adds early return (
return None) when cover fetch fails due tohttpx.TransportError
| @@ -75,6 +75,7 @@ async def _store_cover( | |||
| await f.write(chunk) | |||
| except httpx.TransportError as exc: | |||
| log.error(f"Unable to fetch cover at {url_cover}: {str(exc)}") | |||
| return None | |||
There was a problem hiding this comment.
The early return only handles httpx.TransportError but the function may continue executing and potentially fail in other ways after a transport error. Consider if other cleanup or error handling is needed before returning, or if the function should handle other potential exceptions that could occur during the cover writing process.
Copilot uses AI. Check for mistakes.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
Description
Explain the changes or enhancements you are proposing with this pull request.
Fixes #2247
Checklist
Please check all that apply.
Screenshots