fix: Improve performance on asset screenshot retrieval #2248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When retrieving the related screenshot for a `Save` or `State`, we were retrieving a very heavy representation of the associated `Rom` object, only to iterate through its screenshots to find the one we needed. This change modifies the `Save` and `State` models to directly query the `Screenshot` model, which is much faster and more efficient. The `DBScreenshotsHandler` has been updated to include a new `filter` method that will simplify building queries using SQLAlchemy, something we can extend to other handlers in the future. Fixes #1925.
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
gantoine
approved these changes
Aug 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When retrieving the related screenshot for a
SaveorState, we were retrieving a very heavy representation of the associatedRomobject, only to iterate through its screenshots to find the one we needed.This change modifies the
SaveandStatemodels to directly query theScreenshotmodel, which is much faster and more efficient. TheDBScreenshotsHandlerhas been updated to include a newfiltermethod that will simplify building queries using SQLAlchemy, something we can extend to other handlers in the future.Fixes #1925.
Checklist