Skip to content

fix: Make RetroAchievements hash matching case-insensitive #2240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adamantike
Copy link
Contributor

Description
Fixes #2182.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

@adamantike adamantike requested review from gantoine and zurdi15 August 9, 2025 15:49
Copy link

trunk-io bot commented Aug 9, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

github-actions bot commented Aug 9, 2025

Test Results

548 tests  ±0   547 ✅ ±0   56s ⏱️ -3s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit f13d219. ± Comparison against base commit b160909.

Copy link

github-actions bot commented Aug 9, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8774 6153 70% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/handler/metadata/ra_handler.py 53% 🟢
TOTAL 53% 🟢

updated for commit: f13d219 by action🐍

@adamantike adamantike merged commit c048383 into master Aug 9, 2025
9 checks passed
@adamantike adamantike deleted the fix/retroachievements-case-insensitive-hash-match branch August 9, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Games not identified for RetroAchievements if case does not match exactly
2 participants