Skip to content

fix: Correctly set up dockerignore file #2237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2025
Merged

Conversation

adamantike
Copy link
Contributor

Description

  • Rename file to Dockerfile.dockerignore. As the Dockerfile is not in the root directory, the Docker spec requires the file to be named <dockerfile_name>.dockerignore.
  • Update ignore rules, and include .mypy_cache/ directory.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

* Rename file to `Dockerfile.dockerignore`. As the `Dockerfile` is not
  in the root directory, the Docker spec requires the file to be
  named `<dockerfile_name>.dockerignore`.
* Update ignore rules, and include `.mypy_cache/` directory.
@adamantike adamantike requested review from gantoine and zurdi15 August 8, 2025 18:04
Copy link

trunk-io bot commented Aug 8, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

omfg that explains why it didnt work half the time

@adamantike adamantike merged commit edece77 into master Aug 8, 2025
7 checks passed
@adamantike adamantike deleted the fix/dockerignore branch August 8, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants