Use native 7z to extract files and calculate hashes #2232
Merged
+79
−260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the py7zr Python library dependency with system-level 7zip CLI tool for calculating file hashes from 7zip archives. The change moves from a Python-based approach to executing the system's 7zip binary.
- Removes py7zr dependency from pyproject.toml and associated imports
- Implements new CLI-based 7zip processing using subprocess calls
- Updates Docker configurations to use appropriate 7zip packages
- Removes unrelated frontend navigation code
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Removes py7zr dependency |
| backend/utils/archive_7zip.py | Complete rewrite to use CLI 7z instead of py7zr library |
| backend/handler/filesystem/roms_handler.py | Updates imports and function calls to use new CLI-based approach |
| docker/Dockerfile | Changes from 7zip to p7zip package |
| Dockerfile | Changes from p7zip to p7zip-full package |
| frontend/src/views/Gallery/Search.vue | Removes navigation logic (unrelated to 7z changes) |
| frontend/src/views/Gallery/Collection/BaseCollection.vue | Removes navigation logic (unrelated to 7z changes) |
| frontend/src/components/Details/States.vue | Adds explicit TypeScript type annotation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
py7zradds 30MB+ to the image size in useless dependencies for "compatibility". This PR replaces it with the native7zip/p7ziplibrary, opting to call sub-processes and parse the output.Checklist
Please check all that apply.