-
-
Notifications
You must be signed in to change notification settings - Fork 249
Migrate worker to native rq process #2227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the worker process to use native RQ commands instead of a custom Python worker script. The main change removes the worker.py
file and integrates task initialization into main.py
, while updating deployment scripts to use the native rq worker
and rqscheduler
commands.
- Removes custom
worker.py
script and moves scheduled task initialization tomain.py
- Updates deployment scripts to use native RQ commands (
rq worker
,rqscheduler
) - Refactors watcher to work with
watchmedo
shell command instead of internal observer
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
backend/worker.py | Completely removed - worker functionality moved to native RQ |
backend/main.py | Added scheduled task initialization previously in worker.py |
backend/watcher.py | Refactored from observer pattern to shell command execution |
entrypoint.sh | Updated to use native RQ commands and watchmedo |
docker/init_scripts/init | Updated process management for native RQ commands |
pyproject.toml | Added watchmedo dependency |
Dockerfile | Added venv to PATH for RQ commands |
DEVELOPER_SETUP.md | Removed worker setup instructions |
.vscode/tasks.json | Removed worker launch task |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀🚀🚀
Description
Explain the changes or enhancements you are proposing with this pull request.
Hot on the heels of #2224, we do the same thing but for the worker. Task initialization now happens in
main.py
sinceworker.py
was purged.Checklist
Please check all that apply.