Display an icon on the card if game has notes #2226
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a quick-view feature for game notes by displaying a notebook icon on game cards when notes are present. Users can click the icon to view notes in a modal dialog, reducing the number of clicks needed to access note content.
- Adds a notebook icon on game cards when notes exist
- Creates a new modal dialog component to display note content with markdown rendering
- Removes some unused navigation code from the Platform.vue component
Reviewed Changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/views/Gallery/Platform.vue | Removes unused router import and navigation logic for meta/ctrl+click |
| frontend/src/layouts/Main.vue | Adds the new NoteDialog component to the main layout |
| frontend/src/components/common/Game/Dialog/NoteDialog.vue | New modal component for displaying game notes with markdown support |
| frontend/src/components/common/Game/Card/Base.vue | Adds notebook icon to game cards and handles note dialog display |
Comments suppressed due to low confidence (1)
frontend/src/views/Gallery/Platform.vue:16
- The ROUTES import is still being used in the router.push call on line 130 (visible in context). This removal will cause a compilation error.
import type { Emitter } from "mitt";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Clicking on the icon will display the note content in a window. This saves like 3 clicks, like a quick-view for notes.
Checklist
Please check all that apply.
Screenshots