Skip to content

misc: Add type hints to task classes #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2025
Merged

Conversation

adamantike
Copy link
Contributor

Description
Small change including type hints for the Task base classes, and related fixes to related tests.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Small change including type hints for the Task base classes, and related
fixes to related tests.
@adamantike adamantike requested a review from gantoine August 6, 2025 18:57
Copy link

trunk-io bot commented Aug 6, 2025

Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information.

Copy link

github-actions bot commented Aug 6, 2025

Test Results

548 tests  ±0   547 ✅ ±0   1m 0s ⏱️ -1s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 637a0b7. ± Comparison against base commit f4a65c3.

Copy link

github-actions bot commented Aug 6, 2025

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
8740 6161 70% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
backend/tasks/tasks.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 637a0b7 by action🐍

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah nice 👍🏼

@adamantike adamantike merged commit 305e2d1 into master Aug 6, 2025
9 checks passed
@adamantike adamantike deleted the misc/task-classes-typing branch August 6, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants