[ROMM-2211] Only show missing platforms on lib manage page #2212
+19
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the frontend to use filteredPlatforms instead of allPlatforms throughout the application, which filters out empty platforms to improve user experience by only showing platforms that contain ROMs.
- Replace
allPlatformswithfilteredPlatformsacross multiple components - Add validation for missing ROMs deletion to prevent empty operations
- Improve platform filtering consistency across scan, gallery, and filter views
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/views/Settings/LibraryManagement.vue | Adds validation to prevent empty ROM deletion operations |
| frontend/src/views/Scan.vue | Updates platform selection to use filtered platforms |
| frontend/src/views/Gallery/Platform.vue | Replaces all platform references with filtered platforms |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue | Updates filter drawer to use filtered platforms |
| frontend/src/components/Details/Title.vue | Updates platform lookup for missing file system icons |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Use
filteredPlatformsfor most uses ofallPlatforms, which filters empty platforms (even on scan page).Fixes #2211
Checklist
Please check all that apply.
Screenshots