[ROMM-2155] Fix char bar jumping to wrong game #2208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the fetchRoms function to accept an object parameter instead of positional parameters, which prevents a bug where the character bar was jumping to the wrong game due to incorrect parameter handling.
- Refactored
fetchRomsmethod signature to use destructured object parameters - Updated all calls to
fetchRomsthroughout the codebase to use the new object-based API - Fixed the character bar issue by ensuring the
concatparameter is properly set tofalse
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| frontend/src/stores/roms.ts | Updated fetchRoms method signature to accept destructured object parameters with proper typing |
| frontend/src/components/Gallery/AppBar/common/CharIndexBar.vue | Fixed character bar navigation by explicitly setting concat: false in the new API |
| frontend/src/views/Settings/LibraryManagement.vue | Updated multiple fetchRoms calls to use new object-based API with explicit groupRoms: false |
| frontend/src/views/Gallery/Search.vue | Updated fetchRoms call to use new object-based API |
| frontend/src/views/Gallery/Platform.vue | Updated fetchRoms call to use new object-based API |
| frontend/src/views/Gallery/Collection/BaseCollection.vue | Updated fetchRoms call to use new object-based API |
| frontend/src/components/common/Game/Table.vue | Updated fetchRoms call to use new object-based API |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue | Updated fetchRoms call to use new object-based API |
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Refactored
fetchRomsso it takes an object, which should prevent the issue (not settingconcattofalseon char bar fetch) from happening again.Fixes #2155
Checklist
Please check all that apply.