[ROMM-1949] Fix multi rom download #2206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the multi-ROM download functionality by implementing proper sequencing and timing controls. Instead of relying on basic setTimeout delays that could cause browser blocking, it introduces a more robust system that waits for each download to start before initiating the next one.
- Replaces the simple setTimeout approach with a Promise-based download system
- Adds configurable delay constants for better control over download timing
- Introduces a dedicated
bulkDownloadRomsfunction to handle multiple ROM downloads sequentially
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| frontend/src/services/api/rom.ts | Adds Promise-based download system with configurable delays and new bulk download function |
| frontend/src/components/Gallery/FabOverlay.vue | Updates download handler to use the new bulk download API |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Await download start for first files before queuing the next file for download.
Fixes #1949
Checklist
Please check all that apply.