Fire off search if URL state prepopulated #2205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR improves the search functionality by automatically triggering a search when filters or search terms are present in the URL on component mount. It removes the immediate search emission from the Search view and instead handles it conditionally in the FilterDrawer component.
- Conditional search triggering based on URL state prepopulation
- Debounce configuration updates to prevent leading edge execution
- Search term handling moved later in the mount lifecycle
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/views/Gallery/Search.vue | Removes automatic search emission on mount |
| frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue | Adds conditional search triggering and moves search term handling |
| frontend/src/views/Settings/LibraryManagement.vue | Updates debounce configuration to disable leading edge |
Comments suppressed due to low confidence (1)
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue:292
- [nitpick] The variable name
freshSearchis ambiguous. Consider renaming tohasNewSearchTermorsearchTermFromUrlto better indicate that it represents a search term coming from the URL that differs from the current value.
const freshSearch = urlSearch !== undefined && urlSearch !== searchTerm.value;
frontend/src/components/Gallery/AppBar/common/FilterDrawer/Base.vue
Outdated
Show resolved
Hide resolved
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
8249cf7 to
ef338a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Explain the changes or enhancements you are proposing with this pull request.
Small improvements to search where the filter drawer fires a fetch event on mount of any of the filters are present in the URL.
Checklist
Please check all that apply.