[ROMM-1868] Fix grouping by metadata rows #2203
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
Test Results543 tests 542 ✅ 59s ⏱️ Results for commit cf28e4f. ♻️ This comment has been updated with latest results. |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the ROM sibling grouping functionality by adding support for additional metadata providers (ra_id, hasheous_id, tgdb_id) and modifies the grouping logic to fix missing ROMs from collections. The changes improve the metadata-based grouping system for better ROM organization.
- Adds support for RetroAchievements, Hasheous, and TheGamesDB metadata providers in ROM grouping
- Updates sibling ROM view to include the new metadata ID fields
- Modifies grouping prioritization order and removes platform_id from group concatenation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| backend/handler/database/roms_handler.py | Updates ROM grouping logic to include new metadata providers and modifies group ID generation |
| backend/alembic/versions/0048_sibling_roms_more_ids.py | Database migration to update sibling_roms view with additional metadata ID fields |
Description
Explain the changes or enhancements you are proposing with this pull request.
This PR adds more metadata providers to sibling ROM grouping, and fixes(?) missing ROMs from collections (somehow...).
Fixes #1868
Checklist
Please check all that apply.