Skip to content

Add IPv6 support #2201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

Add IPv6 support #2201

merged 1 commit into from
Aug 5, 2025
+2 −0

Conversation

danielkoster
Copy link
Contributor

Add IPv6 support

Description
This change adds IPv6 support to the nginx running in the docker container. This allows people to access RomM over IPv6 if they want.

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes

Screenshots

@gantoine gantoine requested review from adamantike and Copilot August 4, 2025 18:20
Copilot
Copilot AI reviewed Aug 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds IPv6 support to the nginx configuration in the Docker container, enabling users to access RomM over IPv6 networks.

  • Adds IPv6 listener directives to nginx server blocks
  • Enables dual-stack (IPv4 and IPv6) connectivity for the application

@rommapp rommapp deleted a comment from Copilot AI Aug 4, 2025
adamantike
adamantike approved these changes Aug 5, 2025
View reviewed changes
Copy link
Contributor

@adamantike adamantike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, thanks for your contribution!

@gantoine gantoine merged commit 5b2cc2d into rommapp:master Aug 5, 2025
2 checks passed
@miszterx
Copy link

Hey!
Since you merged this change my host, which has explicit denied ipv6 is failing with starting romm:

INFO:     [RomM][init][2025-08-18 07:16:57] Version: 4.1.3
INFO:     [RomM][init][2025-08-18 07:16:57] 
INFO:     [RomM][init][2025-08-18 07:16:57] No OpenTelemetry environment variables found, disabling OpenTelemetry SDK
INFO:     [RomM][init][2025-08-18 07:16:57] Starting internal valkey
INFO:     [RomM][init][2025-08-18 07:16:57] Running database migrations
INFO:     [RomM][init][2025-08-18 07:16:59] Database migrations succeeded
INFO:	  [RomM][startup][2025-08-18 07:17:02] Running startup tasks
INFO:	  [RomM][startup][2025-08-18 07:17:02] Initializing cache with fixtures data
INFO:	  [RomM][startup][2025-08-18 07:17:02] Startup tasks completed
INFO:     [RomM][init][2025-08-18 07:17:02] Starting backend
INFO:     [RomM][init][2025-08-18 07:17:02] Starting RQ worker
07:17:02 Worker rq:worker:c8b88631709d45f6b222d39894a3d672 started with PID 74, version 2.4.0
07:17:02 Subscribing to channel rq:pubsub:c8b88631709d45f6b222d39894a3d672
07:17:02 *** Listening on high, default, low...
07:17:02 Cleaning registries for queue: high
07:17:02 Cleaning registries for queue: default
07:17:02 Cleaning registries for queue: low
INFO:     [RomM][init][2025-08-18 07:17:04] Starting nginx
2025/08/18 07:17:04 [notice] 107#107: js vm init njs: 00007437E42F4980
2025/08/18 07:17:04 [emerg] 107#107: socket() [::]:8080 failed (97: Address family not supported by protocol)
nginx: [emerg] socket() [::]:8080 failed (97: Address family not supported by protocol)

Can you make it this ipv6 nginx part somehow optional? or configureable in config.yaml?

@adamantike
Copy link
Contributor

@miszterx , thanks for bringing that up. I will work on a fix.

@miszterx
Copy link

@adamantike Thanks! Highly appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@adamantike adamantike adamantike approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danielkoster @miszterx @adamantike @gantoine